fix monorepo-broken version detection and package resolution#172
Open
AaronO wants to merge 1 commit intoblackboardsh:mainfrom
Open
fix monorepo-broken version detection and package resolution#172AaronO wants to merge 1 commit intoblackboardsh:mainfrom
AaronO wants to merge 1 commit intoblackboardsh:mainfrom
Conversation
ELECTROBUN_DEP_PATH was hardcoded to projectRoot/node_modules/electrobun which doesn't exist in monorepos with hoisted node_modules. This caused version detection to fall back to "latest" and all binary/cache paths to break. - Walk up directory tree to find electrobun in node_modules (handles yarn/pnpm/npm/bun workspaces) - Derive .electrobun-cache path from resolved location instead of hardcoding against projectRoot - Replace runtime package.json reads with compile-time version constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELECTROBUN_DEP_PATHwas hardcoded toprojectRoot/node_modules/electrobunwhich doesn't exist in monorepos with hoistednode_modules. This caused version detection to fall back to"latest"and all binary/cache paths & URLs to break.electrobuninnode_modules(handlesyarn/pnpm/npm/bunworkspaces).electrobun-cachepath from resolved location instead of hardcoding againstprojectRootpackage.jsonreads with compile-time version constant