Fix same length values

[sergeykish]

ActiveRecord::StatementInvalid: PG::SyntaxError: ERROR:  VALUES lists must all be the same length

[sergeykish]

That's a sketch, I'll make a cleanup

[sergeykish]

Disabled :disable_timestamps option

[sergeykish]

Returned back :disable_timestamps

[sergeykish]

@bjhaid I'm not sure how to deal with previous rails versions

active_record_bulk_insert/lib/active_record_bulk_insert.rb

Line 43 in cfccf25

def self._bulk_insert_quote(key, value)

[bjhaid]

@sergeykish I am not sure I understand what problem you are attempting to solve with this PR.

[sergeykish]

@bjhaid got it! I've filled in #12 and created spec

[bjhaid]

Have you verified what you have here:

https://github.com/bjhaid/active_record_bulk_insert/pull/11/files#diff-8ac167c90faec485f35cdf33a5dfdba8R19

actually creates the records in the DB with the correct fields, I think this PR also introduces potential bugs, have you tried it with a hash that contains extraneous keys?

BTW I think ensuring that the hashes passed in contains the same set of keys and a default supplied to normalize hashes with fewer keys should be the job of whatever calls bulk_insert and not bulk_insert.

[sergeykish]

Have you verified ... actually creates the records in the DB with the correct fields

Sure, I already use code in production

records = [ 
  { :name => "Foo", :age => 30 },
  { :name => "Bar" } 
]
SampleRecord.bulk_insert(records)

produces

  INSERT INTO "sample_records"
    (name, age, created_at, updated_at)
  VALUES
    ('Foo', 30, '2017-05-05 09:08:30.818160', '2017-05-05 09:08:30.818160'),('Bar', NULL, '2017-05-05 09:08:30.818297', '2017-05-05 09:08:30.818297

have you tried it with a hash that contains extraneous keys

they are not present in the columns and thus ignored

SampleRecord.bulk_insert([{:missing => "Bar"}])

produces

  INSERT INTO "sample_records"
    (name, age, created_at, updated_at)
  VALUES
    (NULL, NULL, '2017-05-05 09:05:31.646982', '2017-05-05 09:05:31.646982')

[bjhaid]

If the column has not null constraints then the query blows up, which is why I think determining what default to use is not the job of bulk_insert, a more adequate solution might be to reject hashes with incomplete keys instead of generating a bad query