Skip to content

[SM-2128] Add sm-2107-cli feature flag - #8826

Open
maxkpower wants to merge 1 commit into
mainfrom
sm/SM-2107-cli-feature-flag
Open

maxkpower wants to merge 1 commit into
mainfrom
sm/SM-2107-cli-feature-flag

Conversation

@maxkpower

@maxkpower maxkpower commented Nov 7, 2026 •

Copy link
Copy Markdown

🎟️ Tracking

SM-2128

📔 Objective

Add the sm-2107-cli feature flag (FeatureFlagKeys.SmCli) to the Secrets Manager section of Constants.cs. It gates the new bw sm CLI in bitwarden/clients, which adds the matching client flag (default off) in bitwarden/clients#23927.

Only registers the flag key; no server behavior changes.

@maxkpower maxkpower added the t:feature Change Type - Feature Development label Nov 7, 2026
@maxkpower
maxkpower marked this pull request as ready for review November 7, 2026 00:55
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a one-line change that adds the sm-2107-cli feature flag key (FeatureFlagKeys.SmCli) to the Secrets Manager section of src/Core/Constants.cs. Both the key string and the constant name appear nowhere else in the codebase, and the entry follows the naming conventions of the flags around it. Per the PR description, this only registers the flag for the client-side bw sm CLI and does not change server behavior.

@maxkpower
maxkpower marked this pull request as draft November 7, 2026 01:00
@maxkpower
maxkpower marked this pull request as ready for review November 7, 2026 01:00
@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.48%. Comparing base (6f35199) to head (d7bef7f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8826   +/-   ##
=======================================
  Coverage   68.48%   68.48%           
=======================================
  Files        2750     2750           
  Lines      117618   117618           
  Branches    10781    10781           
=======================================
  Hits        80554    80554           
  Misses      34524    34524           
  Partials     2540     2540           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant