[zfrick-bw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38203

📔 Objective

Remove the fully rolled-out pm-31920-access-intelligence-azure-file-storage feature flag from the server. This is a prerequisite for PM-38206, the removal of pm-31936-access-intelligence-new-architecture.

The server never branched on this flag. It only provided it to clients, so the constant and its test mocks were the only functional references.

• Remove FeatureFlagKeys.AccessIntelligenceVersion2 from Constants.cs.
• Remove two OrganizationReportControllerTests tests that only mocked the flag. They duplicated ..._NewArchOn_WithFileSize_TakesFileCreatePath and ..._NewArchOn_WithoutFileSize_TakesInlinePath, which assert more, so no coverage is lost.
• Trim the CreateOrganizationReportAsync comment and a test section comment that referenced the removed flag.

The flag has to be removed from the clients before this is merged and deployed. Clients that still read it would see it missing and fall back to their default.

🤖 AI-assisted review

Standard local code review (code-review-local) of the branch commit against origin/main: APPROVE, no findings, nothing deferred. Scope was the committed change only.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the removal of the pm-31920-access-intelligence-azure-file-storage feature flag (FeatureFlagKeys.AccessIntelligenceVersion2) from Constants.cs, the shortened comment in OrganizationReportsController.CreateOrganizationReportAsync, and the two deleted controller tests. Nothing in the repository still references the constant or the flag key, and the controller never branched on it, so server behavior does not change. The remaining NewArchOn_WithFileSize_TakesFileCreatePath, NewArchOn_WithoutFileSize_TakesInlinePath, and NewArchOff_WithFileSize_TakesInlinePath tests still cover each request-shape path. As the description notes, clients must stop reading the flag before this is deployed. The hold label already enforces that order.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.49%. Comparing base (9e5b3ec) to head (df70e56).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (9e5b3ec) and HEAD (df70e56). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (9e5b3ec)	HEAD (df70e56)
	2	1

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8823      +/-   ##
==========================================
- Coverage   74.83%   68.49%   -6.35%     
==========================================
  Files        2750     2750              
  Lines      117618   117618              
  Branches    10781    10781              
==========================================
- Hits        88025    80560    -7465     
- Misses      26936    34517    +7581     
+ Partials     2657     2541     -116     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Banrion]

Held to check the release cycles, confirmed good to continue