Repository navigation
Conversation
AlexRubik
added
t:feature
Contributor
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This review covers head 5216750. The PR adds Code Review DetailsNo code findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dirt/pm-41931/report-exclusions-api #8700 +/- ##
====================================================================
Coverage 74.51% 74.52%
====================================================================
Files 2735 2737 +2
Lines 117243 117274 +31
Branches 10626 10628 +2
====================================================================
+ Hits 87364 87393 +29
- Misses 27215 27219 +4
+ Partials 2664 2662 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Per-user JSON map of cipher report exclusions, a sibling of Archives. Vault write procedures accept the new parameter but never write it, so saving a cipher cannot erase another user's exclusion.
…iphers Reads this user's entry from ReportExclusions into CipherDetails and the cipher response, so the standard sync delivers every exclusion. EF replaces never write the column.
DIRT-owned writer for Cipher.ReportExclusions. Only the user's own personal, not-deleted logins can be excluded, and only the account revision is bumped, so other devices sync without an edit conflict.
PUT ciphers/{id}/exclude-from-reports, behind the health report
exclusions flag. Requires premium, and pushes a cipher sync so the
user's other devices pick up the exclusion.
Repository tests run on every database and pin the scope rules, the per-user read, the revision date behavior, and that Vault replaces keep the exclusion. Adds command and controller unit tests.
… organizations The EF GetManyByUserIdAsync branch for users without organizations rebuilds CipherDetails field by field and dropped ReportExcludedDate, so sync on Postgres, MySQL and SQLite returned null for users with no org. MSSQL was unaffected (its procedure selects every column).
Store { "<userId>": true } instead of the exclusion date, matching the
tech breakdown and the Favorites pattern. Nothing reads the date, and a
flag tells the server less. Ciphers now expose a per-user
ExcludedFromReports boolean in place of ReportExcludedDate.
This PR now holds only the database and data-access changes, so it can merge before the endpoint. The command, controller and their unit tests move to a stacked PR.
Main gained newer migrations, so the SQL script moves to 2026-10-23 and the three EF migrations are regenerated on top of main's model.
Follow the SQL naming guide: Cipher_UpdateManyBrowserHealthExclusions.
AlexRubik
force-pushed
the
dirt/pm-41931/exclude-from-reports-endpoint
branch
from
October 26, 2026 21:58
0792477 to
8bc97ff
Compare
AlexRubik
changed the title
PUT ciphers/{id}/exclude-from-reports, behind the health report
exclusions flag. Requires premium, and pushes a cipher sync so the
user's other devices pick up the exclusion.
AlexRubik
force-pushed
the
dirt/pm-41931/exclude-from-reports-endpoint
branch
from
October 27, 2026 17:27
8bc97ff to
97b6f5d
Compare
…edure Lets the restore feature reuse the procedure. Passing 0 removes the user's key, because the SQL Server read treats any stored value as excluded.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-41931
📔 Objective
This PR adds
PUT ciphers/{id}/exclude-from-browser-health. It is stacked on #8669, which adds the storage. Merge #8669 first.The endpoint:
pm-39196-health-report-exclusionsfeature flag.RevisionDate. This follows Favorites and Folders, so other devices do not get edit conflicts.Tests: unit tests, and a live API test of 31 checks against a local server.
Security note. With this endpoint, the server learns which personal logins a user excluded. The client shows Exclude only on at-risk logins. The nearest precedent is the organization
SecurityTasktable. AppSec must review this before the PR leaves draft.The clients PR that calls this endpoint is bitwarden/clients#24109.
📸 Screenshots
Not applicable. This PR has no UI changes.