Repository navigation
[SM-2126] Limit request access note to 1000 characters - #24445
cd-bitwarden wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24445 +/- ##
=======================================
Coverage 62.13% 62.14%
=======================================
Files 4920 4920
Lines 158013 158014 +1
Branches 25252 25252
=======================================
+ Hits 98175 98190 +15
+ Misses 53179 53165 -14
Partials 6659 6659 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds a 1,000-character limit to the Secrets Manager request-access note in the browser, matching the limit the server already enforces. The form control now uses |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-2126
📔 Objective
Client-side counterpart to bitwarden/server#8809, which caps the Secrets Manager access-request note (
EmailContentonRequestSMAccessRequestModel) at 1,000 characters.Validators.maxLength(1000)to the note field on the request-access form so the form blocks submission before the server rejects it. The component library already renders the localized "must not exceed N characters" error.bit-hintunder the textarea showing the character maximum, reusing the existingcharacterMaximumstring (no new translations).The longest translated default note is under 700 characters, so the prefilled text never trips the validator.