Skip to content

[PM-28139] Remove V1 Linux Biometrics#21571

Merged
quexten merged 4 commits into
mainfrom
km/remove-v1-linux-biometrics
Jul 6, 2026
Merged

[PM-28139] Remove V1 Linux Biometrics#21571
quexten merged 4 commits into
mainfrom
km/remove-v1-linux-biometrics

Conversation

@quexten

@quexten quexten commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28139

📔 Objective

Removes the V1 linux biometric implementation since it has been rolled out, and since it contains a non-fips-approved cryptographic algorithm suite transitively via thread rng.

📸 Screenshots

image

@quexten quexten added the t:tech-debt Change Type - Tech debt label Jun 30, 2026

fn random_challenge() -> [u8; 16] {
let mut challenge = [0u8; 16];
rand::rng().fill_bytes(&mut challenge);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ not fips approved algorithm

@quexten quexten changed the title Remove V1 Linux Biometrics [PM-28139] Remove V1 Linux Biometrics Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.59%. Comparing base (81757da) to head (c0c4125).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21571      +/-   ##
==========================================
+ Coverage   49.57%   49.59%   +0.02%     
==========================================
  Files        4108     4102       -6     
  Lines      129059   128652     -407     
  Branches    19721    19702      -19     
==========================================
- Hits        63977    63810     -167     
+ Misses      60353    60114     -239     
+ Partials     4729     4728       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten quexten marked this pull request as ready for review July 1, 2026 06:30
@quexten quexten requested review from a team as code owners July 1, 2026 06:30
@quexten quexten requested review from dereknance and eligrubb July 1, 2026 06:30
@quexten quexten added the ai-review Request a Claude code review label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the removal of the V1 Linux biometrics implementation, including the Rust biometric/crypto core modules, napi bindings, the LinuxBiometricsV2 feature flag, IPC actions, and the associated service wiring. The V2 LinuxBiometricsSystem is now instantiated directly in MainBiometricsService in place of the feature-flagged runtime swap. Verified that no dangling references to any removed symbols remain and that constructor signature changes are applied consistently across all call sites and specs.

Code Review Details

No findings. Verification notes:

  • LinuxBiometricsSystem is correctly imported and used directly in apps/desktop/src/key-management/biometrics/main-biometrics.service.ts; no leftover dynamic require.
  • No remaining references to removed symbols (LinuxBiometricsV2, enableLinuxV2Biometrics, isLinuxV2BiometricsEnabled, EnableLinuxV2/IsLinuxV2Enabled, the deleted napi biometrics namespace, or the V1 core modules).
  • The deleted core crypto module is distinct from the retained secure_memory::secure_key::crypto submodule and the biometric_v2 module — no cross-references break.
  • Constructor signature reductions on MainBiometricsService and BiometricMessageHandlerService are applied consistently at call sites (main.ts) and updated specs.
  • The existing unresolved thread on the deleted unix.rs line ("not fips approved algorithm") is an author annotation on the code being removed, consistent with the PR objective.

@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@quexten quexten enabled auto-merge (squash) July 1, 2026 07:54

@dereknance dereknance left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah deleted code. My favorite!

@eligrubb eligrubb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@quexten quexten merged commit 8f53cb2 into main Jul 6, 2026
142 of 147 checks passed
@quexten quexten deleted the km/remove-v1-linux-biometrics branch July 6, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants