[PM-28139] Remove V1 Linux Biometrics#21571
Conversation
|
|
||
| fn random_challenge() -> [u8; 16] { | ||
| let mut challenge = [0u8; 16]; | ||
| rand::rng().fill_bytes(&mut challenge); |
There was a problem hiding this comment.
^ not fips approved algorithm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21571 +/- ##
==========================================
+ Coverage 49.57% 49.59% +0.02%
==========================================
Files 4108 4102 -6
Lines 129059 128652 -407
Branches 19721 19702 -19
==========================================
- Hits 63977 63810 -167
+ Misses 60353 60114 -239
+ Partials 4729 4728 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the removal of the V1 Linux biometrics implementation, including the Rust Code Review DetailsNo findings. Verification notes:
|
|
dereknance
left a comment
There was a problem hiding this comment.
Ah deleted code. My favorite!



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-28139
📔 Objective
Removes the V1 linux biometric implementation since it has been rolled out, and since it contains a non-fips-approved cryptographic algorithm suite transitively via thread rng.
📸 Screenshots