[PM-39447] [Shared Unlock] Shared unlock stuck on lock component

[quexten]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39447

📔 Objective

Bug: When two clients sharing unlock are on the lock screen actively, then one unlocks, while the other also unlocks, it remains on the lock component and never navigates away.

This fixes it by adding an external unlock event which the lock components use to navigate away.

📸 Screenshots

N/A

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the shared-unlock lock-screen fix that introduces an externalUnlock$ event so a lock component auto-dismisses when another client unlocks the same account. Verified the new getExternalUnlock$ abstract method is implemented across all three platform services (web, browser, desktop), DI wiring is correct (safeProvider deps arrays match constructors, leader/follower services registered), and subscription teardown is handled via activeAccountChange$, take(1), and destroy$. The three earlier CRITICAL test-breakage findings are resolved — the spec files now provide the new mocks/providers and the "Fix tests" commit addresses them.

Code Review Details

No outstanding findings. Previously flagged test-compilation breakages (lock.component.spec, desktop-lock-component.service.spec, web-lock-component.service.spec) were resolved in this PR's follow-up commit.

[codecov]

Codecov Report

❌ Patch coverage is 36.84211% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.56%. Comparing base (81757da) to head (cf769bd).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...d-unlock/default-shared-unlock-follower.service.ts	0.00%	4 Missing ⚠️
...red-unlock/default-shared-unlock-leader.service.ts	0.00%	4 Missing ⚠️
.../lock/services/extension-lock-component.service.ts	50.00%	3 Missing ⚠️
...nt/lock/services/desktop-lock-component.service.ts	50.00%	3 Missing ⚠️
...gement/lock/services/web-lock-component.service.ts	50.00%	3 Missing ⚠️
...anagement-ui/src/lock/components/lock.component.ts	40.00%	3 Missing ⚠️
apps/browser/src/background/main.background.ts	33.33%	2 Missing ⚠️
...y-management/shared-unlock/shared-unlock-driver.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21446      +/-   ##
==========================================
- Coverage   49.57%   49.56%   -0.01%     
==========================================
  Files        4108     4109       +1     
  Lines      129059   129094      +35     
  Branches    19721    19722       +1     
==========================================
+ Hits        63977    63989      +12     
- Misses      60353    60377      +24     
+ Partials     4729     4728       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
7.7% Duplication on New Code

See analysis details on SonarQube Cloud

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉