Repository navigation
fix(bitwarden-atlassian-tools): enforce the firewall's 7-day minimum release age in pnpm - #302
Merged
Merged
Conversation
…release age in pnpm Bitwarden's install-time package firewall rejects any release younger than 7 days, but pnpm's own default window is 24 hours, so lock file maintenance could commit a release the firewall then refuses on every protected device while CI stayed green. Setting minimumReleaseAge to the same 7 days makes pnpm resolve only releases outside the window and fail a frozen install on a lock file that carries a newer one. The MCP server and the repo root each get their own setting, because pnpm reads the nearest pnpm-workspace.yaml and the root file does not reach the server's separate lock file, nor the installed plugin, which ships without the repo root.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds |
fedemkr
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Follow-up to #301, which pinned around the release-age failure that #275 introduced.
📔 Objective
pnpm now enforces the same 7-day minimum release age as our install-time package firewall, for both the Atlassian MCP server's lockfile and the root lockfile.
pnpm's default window is 24 hours, so lock file maintenance like #275 could commit releases the firewall rejects while CI stayed green, and a frozen install of #275's lockfile now fails on exactly those releases.
Each lockfile needs its own setting, because pnpm reads the nearest
pnpm-workspace.yamland the installed plugin ships without the repo root.🤖 AI-assisted review
Standard local review (
code-review-local): approved with no findings, none deferred.