Repository navigation
fix(bitwarden-atlassian-tools): create link_issues Blocks links in the requested direction - #286
Merged
Merged
Conversation
…e requested direction link_issues put the blocker on outwardIssue, so every Blocks link it created read the opposite way round in Jira. The mapping came from a misreading of a live link's GET response, and the read-back check reused the same mapping, so inverted links were reported as verified. Put the blocker on inwardIssue, and verify by role from the blocker's record so a wrong mapping cannot pass its own check. An inverted link is now reported as such, with its link id. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR fixes |
SaintPatrck
reviewed
Oct 22, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
SaintPatrck
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Found on 2026-10-21 while correcting the dependency links on SHOT-295.
link_issuescreated SHOT-295/297, 297/298 and 297/299 inverted on 2026-09-23, and reproduced the fault live on 2026-10-21 (link 88495).📔 Objective
link_issueswithlinkType: Blocks,blockerKey: A,blockedKey: Breplied "Linked: A blocks B. Verified: …", but Jira stored B blocks A. Every Blocks link the tool has created is inverted.Root cause. The ground-truth example in
createIssueLink's doc comment (PM-39203 / PM-38796) was read backwards. On issue X's record,inwardIssue: Yreads "X is blocked by Y" andoutwardIssue: Yreads "X blocks Y", so that link is PM-38796 blocks PM-39203. The create mapping followed the misreading and put the blocker onoutwardIssue.verifyLinkreused the same mapping, so an inverted link always passed as verified, and the handler test mocked a GET shape that followed the same model.Fix.
resolveLinkDirection: for Blocks, blocker →inwardIssue, blocked →outwardIssue. Verified live: postinginwardIssue: SHOT-295,outwardIssue: SHOT-297created link 88496, which reads SHOT-295 blocks SHOT-297 from both ends. The dry-run payload is built from the same object.verifyLinkchecks by role, independent of the create mapping. It reads the blocker and requires a Blocks entry withoutwardIssue: blocked. If it findsinwardIssue: blockedinstead, it reports the link as created inverted with its id. Links of another type no longer count. Relates is accepted from either side.createIssueLinkandJiraIssueLink, and dropped the unverified claim that the REST mapping is the opposite of acli's--in/--out.link_issuesbefore 2.7.7 is inverted. The CHANGELOG entry tells users to check each one, delete it, and recreate it. Relates links are unaffected.🤖 Generated with Claude Code