Fix errors while executing script - #2
Open
Ash141-trojan wants to merge 2 commits into
Open
Conversation
The script tries to copy non-existent wallpaper during installation , causing error and aborting the install. cp: cannot stat 'bitpunk-theme/wallpapers/wallpaper-bitpunk.jpg': No such file or directory This was introduced originally back in commit ff2a00e as the intended wallpaper was renamed without updating the harcoded value in script Use the correct wallpaper name so the cp succeds.
Apply the wallpaper after it's been copied This requires a shell restart to take place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script fails while trying to copy a non-existent wallpaper as a result of hardcoded value.
Update the script to pick a valid wallpaper from wallpapers/