Support for tags with prefix (rebased)#76
Closed
tony wants to merge 3 commits intobitprophet:masterfrom
Closed
Conversation
tony
force-pushed
the
future-releases-uri-config
branch
from
f3a50a8 to
37f53d9
Compare
tony
added a commit
to tmux-python/libtmux
that referenced
this pull request
Jun 23, 2018
See also: - bitprophet/releases#54 (original PR by @scolby33) - bitprophet/releases#76 (rebased branch of above PR used in this commit) - Feature request: bitprophet/releases#65
Author
|
@bitprophet In 'Next releases' URL: With this PR: https://libtmux.git-pull.com/en/latest/history.html |
|
Thanks @tony for the update on this. I have done rebases on pull requests before and I think the commit authorship is saved, unless you squash everything(?). Either way, I'm not too concerned about the credit and am happy that my contributions were useful! |
…'t have the same link as already existing releases. (Git tags vs. a current development branch, for example)
tony
force-pushed
the
future-releases-uri-config
branch
from
37f53d9 to
9ad1be2
Compare
Author
|
@scolby33 @bitprophet Rebased against 8c01876 |
tony
force-pushed
the
future-releases-uri-config
branch
from
9ad1be2 to
5ef160a
Compare
Author
|
@bitprophet How about now? |
tony
added a commit
to tmux-python/tmuxp
that referenced
this pull request
May 12, 2019
Remove releases in favor of a more sphinx-issues and basic reST structuring. https://github.com/bitprophet/releases was inflexible in cases where we used v<versionnumber> (v1.2.2) and wanted to link back to master. Issue / PR: - bitprophet/releases#54 - bitprophet/releases#76 Other issues is how the behavior did more than styling and issue linking, sometimes patches only intended for minor releases were also added to minor releases. Regardless of what it intended to do, it wasn't compatible with how releases were cut. It does more than the projects I added to needed. Instead of using reST sections, it used list items to represent versions. Which then go on to build html that a section would anyway. This feels out of place when separating versions. Custom roles used in releases were way too much investment for a changelog. It'd be worth seeing if the same job could be done by iterating over node test and linking to issues like GitHub does. e.g #484
Author
|
Sorry this is stale, someone else is okay to carry on the torch - I don't use this package anymore (just prefer plain files now) I will close this, but keep my branch up in case anyone wants to continue (in a fresh PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #54 by @scolby33
I'm not fully sure if scolby gets full credit if I rebase and make a PR. @scolby you're free to use this rebase in your own branch/PR if you'd like. I need this feature on several projects, because they all have broken links at the moment.
See also: #65