fix before/after all hooks not finding tests that aren't direct children of parent#46
Merged
Merged
Conversation
andrejewski
reviewed
Jun 7, 2018
| data.parent.eachTest(function(t) { | ||
| test = test || t; | ||
| }) | ||
| data = test; |
Contributor
There was a problem hiding this comment.
I think we should preserve the original data if no test is found rather than setting undefined.
Contributor
Author
There was a problem hiding this comment.
The way mocha works, if there's no test in the suite or any subsuite, the hook doesn't run (so it shouldn't be able to fail without a test to be found). But it's not a big deal to make the change, so sure.
andrejewski
approved these changes
Jun 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a refinement of #45 -- I just realized that failures on the before all / after all hooks might not find a test to glom onto if there wasn't a test that was a direct sibling. This fix uses eachTest() to always find a suitable test to fail when one of these hooks fails, as long as one exists in the suite.