Skip to content

Verify chain / network on RGB invoice #362

Open

Description

@cryptoquick

Different from #360; We need to verify if an invoice for the wrong network has been provided, and return an error if that is the case. We'll also need tests, and the necessary upstream functionality.

Activity

  1. added this to the 0.7.0 milestone on Aug 29, 2023
  2. oacdutra commented on Nov 2, 2023

    @oacdutra
    Contributor

    Hi @cryptoquick and @josediegorobles , we can make solve it, if add optional parameter in invoice called network. This maintain compatibility with other wallets and prevents the problem use invoices in wrong network. Does make sense?

  3. modified the milestones: 0.7.0, 0.7.1 on Nov 2, 2023
  4. cryptoquick commented on Nov 2, 2023

    @cryptoquick
    MemberAuthor

    This should already be on the RGB invoice struct

  5. oacdutra commented on Nov 2, 2023

    @oacdutra
    Contributor

    This should already be on the RGB invoice struct

    Yes, but it is only used in case you know the beneficiary (see here).

  6. cryptoquick commented on Nov 2, 2023

    @cryptoquick
    MemberAuthor

    So, that would be an invoice that includes a blinded UTXO? That's fine I think.

  7. oacdutra commented on Nov 2, 2023

    @oacdutra
    Contributor

    So, that would be an invoice that includes a blinded UTXO? That's fine I think.

    No, RgbInvoice parse the chain only when beneficiary is a bitcoin address, not when a blind UTXO

  8. cryptoquick commented on Nov 2, 2023

    @cryptoquick
    MemberAuthor

    I see. You're right, we may need to add an optional parameter to the invoice then. I'll also tag @dr-orlovsky and @fedsten on this issue so they're aware of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions