[RFC] dbwrapper: Set global leveldb mmap limit#32447
Closed
laanwj wants to merge 1 commit intobitcoin:masterfrom
Closed
[RFC] dbwrapper: Set global leveldb mmap limit#32447laanwj wants to merge 1 commit intobitcoin:masterfrom
laanwj wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32447. ReviewsSee the guideline for information on the review process. |
Set the default leveldb mmap limit to 4096 from dbwrapper, before creating the first leveldb context. The motivation here is to remove the need for a leveldb patch, see google/leveldb#1265.
965d1a5 to
e331216
Compare
Member
Author
|
Yeah no even "when to call this initialization" isn't clear, this breaks the tests as-is. |
Member
Author
|
See bitcoin-core/leveldb-subtree#52 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the default leveldb mmap limit to 4096 files from dbwrapper, before creating the first leveldb context.
The motivation here is to remove the need for a custom leveldb patch, see google/leveldb#1265.
After looking into this i'm not as sure whether this is what we want to do: