388: fix incorrect example#1874
Merged
Merged
Conversation
As per the test vectors, musig key expressions require the aggregation step to precede the change/address_index derivations.
jonatack
added
Proposed BIP modification
jonatack
reviewed
Jun 22, 2025
| * <tt>wsh(multi(2,@0/**,@1/**))</tt> - SegWit 2-of-2 multisig, keys in order. | ||
| * <tt>sh(sortedmulti(2,@0/**,@1/**,@2/**))</tt> - Legacy 2-of-3 multisig, sorted keys. | ||
| * <tt>tr(musig(@0/**,@1/**))</tt> - MuSig2 2-of-2 in the taproot keypath | ||
| * <tt>tr(musig(@0,@1)/**)</tt> - MuSig2 2-of-2 in the taproot keypath |
Member
There was a problem hiding this comment.
This does remove the contradiction between the example here being the same as the invalid policy example in line 313 below.
Is there further explanation somewhere about the statement in line 313 "Derivation before aggregation is not allowed in wallet policies (despite being allowed in BIP-390)"?
Contributor
Author
Member
There was a problem hiding this comment.
Thanks! Fine for a different pull, but if there is no further explanation on this in the BIP, it may be good to add some (along with those links).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the test vectors, musig key expressions require the aggregation step to precede the change/address_index derivations in wallet policies.