Skip to content

BIP-85: formatting and changelog updates, and add word cases for application 39'#1691

Merged
jonatack merged 4 commits into
bitcoin:masterfrom
akarve:bip85-details
Nov 14, 2024
Merged

BIP-85: formatting and changelog updates, and add word cases for application 39'#1691
jonatack merged 4 commits into
bitcoin:masterfrom
akarve:bip85-details

Conversation

@akarve

@akarve akarve commented Oct 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

jonatack
jonatack reviewed Oct 26, 2024
View reviewed changes

@jonatack jonatack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Comment thread bip-0085.mediawiki
Comment thread bip-0085.mediawiki Outdated
@jonatack jonatack added the PR Author action required Needs updates, has unaddressed review comments, or is otherwise waiting for PR author label Nov 7, 2024
@jonatack jonatack mentioned this pull request Nov 8, 2024
Merged
@akarve akarve requested a review from jonatack November 9, 2024 21:25
@jonatack jonatack added Proposed BIP modification PR by non-owner to update BIP content and removed PR Author action required Needs updates, has unaddressed review comments, or is otherwise waiting for PR author labels Nov 14, 2024
jonatack
jonatack reviewed Nov 14, 2024
View reviewed changes

@jonatack jonatack left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b398219

Only changes are presentation/formatting and adding two entries to the application 39' table.

@jonatack jonatack changed the title BIP-85: Move and reorder changelog to be near implementations, note 15' and 21' word cases for application 39' BIP-85: formatting and changelog updates, and add word cases for application 39' Nov 14, 2024
@jonatack jonatack merged commit 16a23b7 into bitcoin:master Nov 14, 2024
@akarve akarve deleted the bip85-details branch November 14, 2024 02:26
@bitcoin bitcoin deleted a comment from Karthik-0521 Nov 14, 2024
@bitcoin bitcoin deleted a comment from Karthik-0521 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonatack jonatack jonatack left review comments

Assignees

No one assigned

Labels

Proposed BIP modification PR by non-owner to update BIP content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akarve @jonatack