fix(auth): clear the mobile feedback FAB from the OAuth sign-in row - #852
Merged
Merged
Conversation
Visitor feedback on /auth?mode=login: at 320x800 the GitHub sign-in button's bottom-right corner sat under the fixed FleetCrown feedback FAB (bottom-right, 48px, max z-index), which steals the tap — costing signups on the page every logged-out /messages visitor lands on. The widget itself isn't in this repo (external embed), so the fix is on our side: below 360px, text wrapping in the heading makes the page ~45px taller, pushing the OAuth row into the FAB's fixed corner. Trimmed non-essential vertical rhythm (never touch-target sizes) with max-[359px] variants so the row lands with ~47px clearance. Verified with Playwright at 320/359/360/375/390/430px — clear at every width, identical to before at 360px+ where it was never a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://orangecat.ch/auth?mode=login&from=%2Fmessages(where every logged-out/messagesvisitor lands): at 320×800, theSign in with GitHubbutton's bottom-right corner sits under the fixed FleetCrown feedback FAB (#fleetcrown-feedback-host,bottom:16 right:16, 48px, max z-index) — the FAB steals the tap. Cost: signups on the sign-in page.fleetcrown.orangecat.ch/widget.js, loaded once inlayout.tsx) — not in this repo, so its own positioning isn't something this PR can change or verify.x166-288/y701-745; a Playwright repro against the real page (with/api/auth/oauth-providersmocked to render the OAuth row, since this sandbox has no live provider config) landed it at the identicalx166-288/y701-745, overlapping the FAB'sy736-784band by 9px.max-[359px]:only (an arbitrary Tailwind variant, notailwind.config.tschange). No touch-target sizes changed. Viewports ≥360px are untouched (and were never affected — the overlap is a narrow-viewport-only artifact of text reflow).Test plan
npx tsc --noEmit— cleannpx eslint src/app/auth/page.tsx src/app/auth/AuthSocialLogin.tsx— cleannpm run test:unit(2638 tests) and full pre-push suite — greenx166-288/y701-745(9px vertical overlap with the FAB'sy736-784reserved corner) → after fix atx166-288/y645-689, 47px clear.fleetcrown.orangecat.ch+ noFLEETCROWN_FEEDBACK_TOKENin this sandbox) or real OAuth provider config — verification used a same-geometry synthetic overlay for the FAB and a mocked provider-list response; both are documented above with exact before/after coordinates so the numbers are checkable against the live site.🤖 Generated with Claude Code