refactor(cat): the grounding harness is imported, not mirrored - #846
Merged
Merged
Conversation
Phase 2 of the fleet AI-engine plan, OrangeCat half. src/services/agent-core was a byte-identical mirror of FleetCrown's agent/core — "deliberate and temporary" by its own README, which named extraction to a package as the exit. ai-kit v0.6.2 is that exit: both apps import ai-kit/grounding, and the mirror plus everything that existed only to police it is deleted. What made this repo the hard consumer: jest. This config's own NOTE says it — the ts-jest transform compiles only .ts/.tsx, so an ESM-only .js dependency cannot be whitelisted via transformIgnorePatterns. Fixed in the package, not here (ai-kit's v0.4 lesson): v0.6.2 ships a CommonJS twin of the grounding and registry subpaths behind an exports `require` condition, so jest resolves it with ZERO config in this repo. The grounding suites pass unmodified. agent-core-grounding.test.ts loses its mirror-integrity half: there is no mirror left to check. (That half also self-skipped in CI, which clones one repo at a time — it only ever ran on a laptop with both checkouts side by side. A gate that runs where nobody is looking and skips where everybody is was part of why the extraction won.) The Cat-policy half — invented attributes about the user's own records are caught, general economic knowledge is left alone — is unchanged and keeps running. First ai-kit install in this repo. The original holdout reason (this repo's model registry is richer than ai-kit's chain) is being resolved in the direction SHARED.md asked a human to pick: the engine gained a registry (ai-kit/registry, with the paid/free boundary as a validated field) rather than this repo keeping a second source of model truth. Migrating config/ai-models.ts onto it is the next phase, not this commit. type-check clean; grounding suites 12/12 on the package import. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WqKqMnHQHSmkGFfc5t7Rxn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OrangeCat half of the mirror retirement (fleet AI-engine plan, Phase 2).
src/services/agent-coredeleted; both apps now importai-kit/grounding(v0.6.2). Jest needs ZERO config: the package ships a CommonJS twin behind an exportsrequirecondition — the fix lives in the package per ai-kit's own v0.4 lesson, not in this repo's jest config.ai-kit/registry), per SHARED.md's parked human decisionFleetCrown twin PR follows — its copy dies the same way.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WqKqMnHQHSmkGFfc5t7Rxn