fix(directory): a third audit fixture survived the filter that hid its two siblings - #845
Merged
Conversation
…s two siblings Verifying #843 on the live site showed the context switcher had gone from three junk groups to one: "Audit WF009 …" and "Audit WF009b …" were correctly hidden, and "Audit Group 1783191071580" was still sitting there. `FIXTURE_GROUP_TITLE` is an allow-list of wordings we happened to have seen — `audit wf`, `ephemeral verify`, `workflow audit`. Audits keep inventing new ones, so the list is always one fixture behind, and the failure is silent: the row simply looks like a team the user joined. So match the *generating* signature instead of the wording: an audit-ish first word followed by the millisecond epoch a fixture appends to keep names unique. Keying on the timestamp is what makes widening safe — a real group is named by a person, and people do not append an epoch. That matters more here than in most products, because OrangeCat is heading for governance, where "Audit Committee" is a group somebody will genuinely create. Tests pin both directions, and the predicate is proven by mutation: drop the new clause and "Audit Group 1783191071580" comes back. Because this is the shared SSOT, it fixes Discover and People too, not just the switcher. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sh5aTRjzkcZkTyiu9D5RCM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(directory): a third audit fixture survived the filter that hid its two siblings
Verifying #843 on the live site showed the context switcher had gone from three
junk groups to one: "Audit WF009 …" and "Audit WF009b …" were correctly hidden,
and "Audit Group 1783191071580" was still sitting there.
FIXTURE_GROUP_TITLEis an allow-list of wordings we happened to have seen —audit wf,ephemeral verify,workflow audit. Audits keep inventing newones, so the list is always one fixture behind, and the failure is silent: the
row simply looks like a team the user joined.
So match the generating signature instead of the wording: an audit-ish first
word followed by the millisecond epoch a fixture appends to keep names unique.
Keying on the timestamp is what makes widening safe — a real group is named by a
person, and people do not append an epoch. That matters more here than in most
products, because OrangeCat is heading for governance, where "Audit Committee"
is a group somebody will genuinely create. Tests pin both directions, and the
predicate is proven by mutation: drop the new clause and "Audit Group
1783191071580" comes back.
Because this is the shared SSOT, it fixes Discover and People too, not just the
switcher.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Sh5aTRjzkcZkTyiu9D5RCM