fix(security): bind orangecat to localhost only, not every interface - #830
Merged
Conversation
launch.sh did `unset HOSTNAME` before starting the standalone server. That does not default to localhost — Next's standalone server reads HOSTNAME as the bind address, and unsetting it falls back to Next's own default, 0.0.0.0 (every interface). Confirmed against the actual bind on the box: orangecat-app was listening on 0.0.0.0:4003, not 127.0.0.1:4003 like every other app in the fleet. Not an active incident — ufw's default-deny only allows 22/80/443, so the port was never actually internet-reachable — but relying on the firewall alone to cover a bind-address mistake is exactly the kind of thing that breaks quietly the day firewall config changes for an unrelated reason. Already applied directly to the running box (this file is vendored TO the box, not FROM it on regular deploys — deploy-selfhost.sh preserves whatever launch.sh is already there rather than overwriting it from the repo, per its own comment). This commit is the repo catching up to what's already live, so the next full box provision starts from the correct file instead of reintroducing the bug. Same fix shipped for fleetcrown (bitbaum/fleetcrown#437) — this repo had the identical bug, independently. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y9rKLxddothnXEtY6KDziN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launch.shdidunset HOSTNAMEbefore starting the standalone server. That does not default to localhost — Next's standalone server readsHOSTNAMEas the bind address, and unsetting it falls back to Next's own default,0.0.0.0(every interface). Confirmed against the actual bind on the box:orangecat-appwas listening on0.0.0.0:4003, not127.0.0.1:4003like every other app in the fleet.Not an active incident — ufw's default-deny only allows 22/80/443, so the port was never actually internet-reachable — but relying on the firewall alone to cover a bind-address mistake is exactly the kind of thing that breaks quietly the day firewall config changes for an unrelated reason.
Already applied directly to the running box — this file is vendored TO the box, not FROM it on regular deploys (
deploy-selfhost.shpreserves whateverlaunch.shis already there rather than overwriting it from the repo, per its own comment). This PR is the repo catching up to what's already live, verified with 5 repeated health checks post-restart, so the next full box provision starts from the correct file instead of reintroducing the bug.Same fix shipped for fleetcrown (bitbaum/fleetcrown#437) — that repo had the identical bug, independently.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Y9rKLxddothnXEtY6KDziN