chore(ci): add single verify script as SSOT for pre-build checks - #10
Open
catomean wants to merge 1 commit into
Open
chore(ci): add single verify script as SSOT for pre-build checks#10catomean wants to merge 1 commit into
catomean wants to merge 1 commit into
Conversation
Bundle the pre-build check chain (lint -> typecheck -> unit tests with coverage) into one `npm run verify` script so local and CI run the exact same gate and cannot drift. Add a `typecheck` script (tsc --noEmit) so the chain uses named scripts throughout. CI now calls `npm run verify` verbatim instead of re-listing lint, tsc and jest inline. The two former check jobs (lint-and-typecheck + unit-tests) are consolidated into one `verify` job; the coverage artifact upload is preserved (jest --coverage still enforces coverageThreshold, and jest auto-enables CI mode via CI=true, so the old `--ci` flag is redundant). Gate, test set, migrations and deploy are unchanged. Add AGENTS.md documenting stack, dev/verify commands, Prisma migration location, and the Vercel deploy path (migrate-on-deploy). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduces one
npm run verifyscript as the single source of truth for the pre-build check chain, so local and CI can no longer drift.package.json: addtypecheck(tsc --noEmit) andverify(npm run lint && npm run typecheck && npm test -- --coverage)..github/workflows/ci.yml: the check stage now runsnpm run verifyverbatim instead of re-listing lint / tsc / jest inline. The two former check jobs (lint-and-typecheck+unit-tests) are consolidated into oneverifyjob;build/e2estill gate on it.AGENTS.md: new — stack, dev/verify commands, Prisma migration location, Vercel migrate-on-deploy path.Behavior preserved
jest --coveragestill enforcescoverageThresholdfromjest.config.ts.--ciflag is dropped because Jest auto-enables CI mode whenCI=true(GitHub Actions) — behavior in CI is identical.Verified locally
npm run verifyis green end-to-end:🤖 Generated with Claude Code