fix(ci): declare the failing-job list before the branch that can skip it - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the red-base carve-out: it declared the failing-job list inside
the
elsebranch of the "does the base have CI history?" check, butset -uison and the merge site always reads it.
So on a base branch with no CI history at all, the sweep took the
"proceeding" path and died:
That is auto-merge dead for every PR in the repo, not a degraded path. Latent
here because this base does have CI history — but it is one fresh repo away from
being real, and it was introduced by my own change.
Fixed by declaring it once, before the branch that can skip the assignment.
Covered upstream by a regression test that runs the real script against a
ghreporting no CI history.
🤖 Generated with Claude Code