ci: make the release a reconciler, not a trigger - #17
Merged
Conversation
The self-releasing workflow I merged an hour ago would not have released anything, and the proof is in this repo: #16 merged to main and no publish run started. threadkit's identical change did fire — because I merged that one by hand with a user token. auto-merge merges with GITHUB_TOKEN, and a push made with that token starts no workflow. So `on: push: branches: [main]` silently does not fire for exactly the merges that matter here. This is the no-cascade rule already documented in CLAUDE.md, and I walked into it while writing the thing meant to remove manual steps. Two fixes, because one of them is a promise and the other is a mechanism: - auto-merge.yml carries REARM_WORKFLOWS, whose comment says "keep this in sync when a push-triggered workflow is added". I added one and did not. Now listed. - More importantly: publish.yml gains an hourly schedule. The question it asks — "is package.json's version on the registry?" — is idempotent, so asking it on a timer costs one `npm view` when there is nothing to do and repairs a missed release when there is. A hand-maintained list of workflows to re-arm is something to keep correct forever; a reconciler is correct by construction. This matches how deploys already work in the fleet: compare desired against actual and act on the difference, rather than trusting an event to arrive. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The self-releasing workflow I merged an hour ago would not have released anything, and the proof is in this repo: #16 merged to main and no publish run started. threadkit's identical change did fire — because I merged that one by hand with a user token.
auto-merge merges with
GITHUB_TOKEN, and a push made with that token starts no workflow. Soon: push: branches: [main]silently doesn't fire for exactly the merges that matter. This is the no-cascade rule already documented in CLAUDE.md, and I walked into it while writing the thing meant to remove manual steps.Two fixes — one is a promise, one is a mechanism
The promise:
auto-merge.ymlcarriesREARM_WORKFLOWS, whose own comment says "keep this in sync when a push-triggered workflow is added". I added one and didn't. Now listed.The mechanism:
publish.ymlgains an hourly schedule. The question it asks — ispackage.json's version on the registry? — is idempotent, so asking it on a timer costs onenpm viewwhen there's nothing to do, and repairs a missed release when there is.A hand-maintained list of workflows to re-arm is something to keep correct forever. A reconciler is correct by construction.
This matches how deploys already work in the fleet: compare desired against actual and act on the difference, rather than trusting an event to arrive.
🤖 Generated with Claude Code