ci(lint): do not lint per-session worktrees as source - #12
Merged
Conversation
ESLint ignore patterns are anchored at the project root, so 'dist/**'
does not match '.claude/worktrees/x/dist/**'. Any session working in a
worktree therefore had its own generated output linted as source:
verify reported 10 errors ('Response' is not defined in dist/server.js,
'URL' is not defined in a test) none of which were in the checkout being
tested. It blocked a release attempt.
Verified both directions: a file planted under .claude/ produces 5 errors
without this entry and none with it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run verifyfailed with 10 errors that were not in the code being verified:ESLint's
ignorespatterns are anchored at the project root, sodist/**matches only the top-leveldist/, not.claude/worktrees/x/dist/. Every session that works in a worktree gets its own generated output linted as source — and sinceverifygates the release, it blocked a publish for reasons unrelated to the package.Adds
.claude/**toignores.Verified both directions. A file planted at
.claude/worktrees/fake/dist/server.jscontainingnew Response(),new URL(...)and an undefined call:.claude/**: 5 errorsnpm run verify: 19/19 pass.🤖 Generated with Claude Code