feat!: make mapping_type optional #486
Merged
Merged
Conversation
theferrit32
reviewed
Jun 23, 2026
theferrit32
reviewed
Jun 23, 2026
theferrit32
approved these changes
Jun 23, 2026
71a7264 to
fc9f44f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #462
I think this was a mistake in how we designed the endpoints -- we want a way to retrieve all mappings, but a path param can't be optional. It also makes more sense to me that
mapping_typewould be like a filter on the/mappings/path rather than a subtype.So the new path looks like
GET /objects/<vrs_id>/mappings?mapping_type=liftover_toorGET /objects/<vrs_id>/mappingsAlternatives considered
GET /objects/<vrs_id>/mappingsendpoint that retrieves all mappings. I went ahead with just changing the existing endpoint for the reasons above.