feat: register protein sequence consequence/canonical allele catvars#470
Merged
Conversation
ca48aec to
ec123d5
Compare
Contributor
Author
|
pulled in latest commits to main + added more tests |
theferrit32
reviewed
Jun 23, 2026
Comment on lines
+39
to
+41
| sequenceReference=vrs.SequenceReference( | ||
| refgetAccession="SQ.cQvw4UsHHRRlogxbWCB8W-mKD4AraM9y", | ||
| ), |
Contributor
There was a problem hiding this comment.
Can we add a moleculeType="protein" or moleculeType=vrs.MoleculeType.PROTEIN here?
Contributor
Author
There was a problem hiding this comment.
Yeah. I meant to do this before, but also updated the molecule type validation function to trust moleculeType blindly.
theferrit32
reviewed
Jun 23, 2026
theferrit32
reviewed
Jun 23, 2026
theferrit32
approved these changes
Jun 23, 2026
79cab79 to
33ae7d7
Compare
33ae7d7 to
b93be23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #453
Decisions
/categorical_variantsnot/categorical_variations. I don't even know which is correct at this pointidfield is justclingen.allele:CA12345. And similarly, fetching that specific catvar isGET /categorical_variants/canonical_alleles/clingen.allele:CA12345ga4gh.cat_vrsrecipes, a couple reasonslen(constraints) == 1)field_validatorbecause it might require seqrepo access. Alternatives here could be 1) requiring the submitter to explicitly declare molecule type and trusting it, or 2) injecting validation context into the fastapi route validation logic, but that looked like it was going to be insane. It's also possible that this function will duplicate work from the projection end point so whichever one gets merged second can resolve that.relationsto the input or output objects yet, pending final determination on how we implement our search functions. But broadly, I think you could just make sure to add in the right values when the object is coming back out to the user. Not sure if it's worth validating them on the way in.Routes
PUT /categorical_variants/canonical_alleles-- to register a CAGET /categorical_variants/canonical_alleles/<id>-- to fetch a CA by IDPUT /categorical_variants/protein_sequence_consequences-- to register a PSQGET /categorical_variants/protein_sequence_consequences/<id>-- to fetch a PSQ by ID