Repository navigation
Release v1.9.3: fix doubled v in cover version badge - #64
Merged
Merged
Conversation
build-cover-dist.sh substitutes {{VERSION}} with an already-prefixed
v${VERSION}, but cover/index.html wrote v{{VERSION}} — so every publish
doubled the prefix in both the hero badge and the footer. The live site
reads "vv1.8.0"; a rebuild at the current tag produced "vv1.9.2".
Because the doubling happens at build time it recurs on every publish and
cannot be fixed by editing rendered output — the template itself has to
carry a bare {{VERSION}}.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The live landing page reads
vv1.8.0, and a rebuild at the current tag producedvv1.9.2:build-cover-dist.shsubstitutes{{VERSION}}with an already-prefixedv${VERSION}:but
cover/index.htmlwrotev{{VERSION}}in both the hero badge and the footer — so thevwas applied twice. Every publish since the placeholder was introduced has shipped the doubled prefix.Why the template, not the output
The doubling happens at build time, so it regenerates on every publish. Editing the rendered
dist-cover/output (or the staledocs/cover.htmlcopy) fixes one artifact and leaves the next build broken. The template has to carry a bare{{VERSION}}.Fix
v{{VERSION}}→{{VERSION}}in both places. Verified by rebuilding: the badge now injects asv1.9.3.Note
docs/cover.htmlis a stale committed copy of the rendered page — it is not the publish source (cover/index.htmlis, perbuild-cover-dist.sh'sCOVER_SRCdefault) and nothing references it. Left alone here; it should probably be deleted in a follow-up.🤖 Generated with Claude Code