Repository navigation
fix: wire --show-processes and --proc-filter through --json/--serve export backends - #47
Merged
Merged
Conversation
…xport backends Export modes (--json/--serve) silently dropped per-process GPU data (processes was always []). CLI routing now forwards both flags to run_json_stream/serve_prometheus, which pass them to Monitor. - actop.py: _run_export reads show_processes/proc_filter from args; --proc-filter without --show-processes implies it - export.py: run_json_stream and serve_prometheus accept keyword include_processes/proc_filter; snapshot_to_prometheus emits 6 per-process labelled gauges when processes are present - Delete 8 redundant CLI default-value assertion tests; add 2 missing functional tests (proc-filter implier, --serve --show-processes via HTTP) - Strengthen testing rule in CLAUDE.md with a litmus test and explicit prohibition against standalone default-value assertions - Bump to 1.6.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Export modes (
--json/--serve) silently dropped per-process GPU data —processesin every NDJSON record was always[], even though the TUI (tkey) showed populated per-process data.--show-processesand--proc-filterwere honored only by the TUI path.Changes
actop/actop.py:_run_exportreadsshow_processes/proc_filterfrom args, forwards to both backends.--proc-filterwithout--show-processesimplies it.actop/export.py:run_json_streamandserve_prometheusaccept keywordinclude_processes/proc_filter, pass toMonitor.snapshot_to_prometheusemits 6 per-process labelled gauges (actop_process_cpu_percent,actop_process_cpu_time_share,actop_process_gpu_time_share,actop_process_attributed_watts,actop_process_rss_bytes,actop_process_num_threads) when processes are present.--json --proc-filter,--serve --show-processesvia HTTP GET/metrics).CLAUDE.md: Strengthen testing rule with litmus test and explicit prohibition against standalone default-value/shape-assertion tests.Validation
On-device (M4 Max):
actop --json --show-processesnow emits non-emptyprocesseswithgpu_time_sharerows.--serve --show-processesexposes per-process gauges at/metrics.Patch bump to 1.6.2.