Repository navigation
fix(e2e): nightly expectation, timeout message, unstamped janitor objects - #610
Merged
Merged
Conversation
The runner turns a {items,truncated,next,total} listing into a list, so
length(items) raised JMESPathTypeError and the nightly run stayed red.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…learned subprocess.TimeoutExpired escaped the step and its traceback printed the rendered argv, uid included. The step now fails with its own error and the argv goes through hidden(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
--older-than 0s counted a name with no run stamp as stale: the janitor printed it as skipped and then deleted it. Only an object that carries a stamp can age now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
мержи |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
JMESPathTypeErroronlength(items)over a list); a timeout printed the rendered argv with a uid;--older-than 0sdeletede2e-handmadeafter printing "skipped".After:
uv run pytest->8145 passed, 5 skipped, coverage 100.00%. New tests fail without the fix (janitor test verified red against the oldjanitor.py):test_a_step_that_times_out_fails_without_the_value_the_run_learned-> message is[s/slow] `ycli users get <uid>` timed out after 120stest_an_object_without_a_run_stamp_is_never_stale_even_at_a_zero_cutoffMerge Danger
Door: two-way
Blast Radius: e2e only
Test tooling and one janitor predicate; no
src/change.🤖 Generated with Claude Code