Skip to content

fix(e2e): nightly expectation, timeout message, unstamped janitor objects - #610

Merged
bim-ba merged 3 commits into
mainfrom
fix/e2e-nightly
Nov 19, 2026
Merged

bim-ba merged 3 commits into
mainfrom
fix/e2e-nightly

Conversation

@bim-ba

@bim-ba bim-ba commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Summary

e2e nightly
  forms/survey_options  answers, answers-raw: length(items) -> length(@)   # runner already unwraps the listing
  runner._run_step      driver.run -> _drive: TimeoutExpired -> ScenarioError, argv through hidden()
  janitor.sweep         stale = Leftover.stale_by(cutoff)                   # unstamped name never ages

Evidence

  • Before: nightly red since 2026-11-10 (JMESPathTypeError on length(items) over a list); a timeout printed the rendered argv with a uid; --older-than 0s deleted e2e-handmade after printing "skipped".
    After: uv run pytest -> 8145 passed, 5 skipped, coverage 100.00%. New tests fail without the fix (janitor test verified red against the old janitor.py):
    • test_a_step_that_times_out_fails_without_the_value_the_run_learned -> message is [s/slow] `ycli users get <uid>` timed out after 120s
    • test_an_object_without_a_run_stamp_is_never_stale_even_at_a_zero_cutoff
    • No runner test replays scenario expressions, so the YAML fix has no offline test; it is verified live by the next nightly.

Merge Danger

Door: two-way

Blast Radius: e2e only

Test tooling and one janitor predicate; no src/ change.

🤖 Generated with Claude Code

bim-ba and others added 3 commits November 19, 2026 01:52
The runner turns a {items,truncated,next,total} listing into a list, so
length(items) raised JMESPathTypeError and the nightly run stayed red.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…learned

subprocess.TimeoutExpired escaped the step and its traceback printed the
rendered argv, uid included. The step now fails with its own error and
the argv goes through hidden().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
--older-than 0s counted a name with no run stamp as stale: the janitor
printed it as skipped and then deleted it. Only an object that carries
a stamp can age now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bim-ba

bim-ba commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

мержи

@bim-ba
bim-ba merged commit 6065b60 into main Nov 19, 2026
12 of 13 checks passed
@bim-ba
bim-ba deleted the fix/e2e-nightly branch November 19, 2026 19:45

This branch had an error being deployed

1 failed deployment
yandex-e2e — 2f19f4e2 Deployed Nov 19, 2026 by bim-ba via prepare #760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant