Skip to content

ci(e2e): a pull request's live run waits for a required reviewer - #590

Open
bim-ba wants to merge 1 commit into
mainfrom
ci/e2e-two-environments
Open

bim-ba wants to merge 1 commit into
mainfrom
ci/e2e-two-environments

Conversation

@bim-ba

@bim-ba bim-ba commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

A pull request from a branch of this repository ran the branch's own e2e runner and janitor with the live credentials, with nothing to approve: the yandex-e2e environment had no protection rule. Found by the review in #459.

What changes

  • The two e2e jobs take yandex-e2e-pr on a pull request and yandex-e2e otherwise.
  • e2e/README.md says which environment a run reads its credentials from.

Repository settings (already applied, read back from the API)

Environment Rule Used by
yandex-e2e deployment branches: main only nightly and manual runs; they do not wait
yandex-e2e-pr one required reviewer pull requests; each run waits for approval

A branch cannot switch itself to yandex-e2e: that environment refuses any ref but main. Forks still skip the live jobs.

Before merging

Both secrets are set in yandex-e2e-pr (2026-10-11); this pull request's own e2e run is waiting there for approval. Approving it is the end-to-end check of the gate.

Until this is merged, the e2e jobs of other pull requests are refused by yandex-e2e, which is the safe side.

Checked

tests/docs, tests/tooling, tests/architecture: 1195 passed. Not run: the full suite, and the workflow itself (its first run is this pull request's).

🤖 Generated with Claude Code

A pull request from a branch of this repository runs the branch's own runner and janitor with the live credentials. Its jobs now use the yandex-e2e-pr environment, where each run waits for a required reviewer; yandex-e2e takes the main branch only, so the nightly and manual runs do not wait. Both rules are repository settings, which a branch cannot edit.

Refs #459.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch had an error being deployed

1 failed deployment
yandex-e2e-pr — 1191d344 Deployed Oct 11, 2026 by bim-ba via live (all) #717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant