Repository navigation
fix(datalens): the models follow the specification of 2026-10-10: the favorite flags are deprecated - #570
Merged
Conversation
… favorite flags are deprecated Regenerated from the specification DataLens publishes today. The `includeFavorite` arguments and `isFavorite` fields of nine sections now say they are deprecated, as the specification does, and the output schemas of the tools that return them carry it. The specification also has a new section, Favorites (`checkFavorites`, `listFavorites`). Its models are generated; the two operations are listed as not wrapped, with the reason that wrapping them is not decided. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 10, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataLens changed its published specification after the models were last regenerated (2026-10-07). This brings the generated models, the snapshot and the README numbers up to it. Mechanical: the generator itself is not changed.
What the regeneration changed, by kind
includeFavoritearguments andisFavoritefields now carrydeprecated=Trueand "will be removed in a future API version" in their descriptions, in nine generated modules: dashboard, editor, html_pages, navigation, ql, reports, sql_queries, wizard, workbookdatalens/schemas/favorites.py(96 lines): the models of a new section, FavoritescheckFavorites,listFavorites: inscripts/api_snapshot/datalens.json, and inNOT_WRAPPEDwith the reason "new section published 2026-10, wrapping not decided". They are not wrapped here; whether to wrap them is a decision for the ownerhasMoreRowsin a result ofsqlqueries run(RunSqlQueryResultResultsItem): whether the statement returned more rows than the reply holds. The model now declares it; before, it was kept as an undeclared extraFollow-ups by generation:
scripts/datalens_schemas.sha256;tests/snapshots/mcp_output_schemas.txt(the output schemas of 11 tools now carry the deprecation); the README "Against the published API" numbers were regenerated (gen_coverage.py --write): DataLens published 141 → 143, wrapped 134, not wrapped on purpose 7 → 9.The generated CLI and MCP reference did not change: no help text or tool description takes its words from the deprecated fields. The hand-written help of
--include-favoritestill does not say "deprecated"; I left it, since it is not generated.Why
fixand notchoreThe output schemas of tools change, so a client sees the deprecation; that should reach a release.
The specification this came from
Saved copy:
~/.cache/ycli-research/name/dl/spec.jsonon the machine that ran this, fetched from https://api.datalens.tech/json/ on 2026-10-10, sha256798680dfba3eca36573e883a1796c5fea3a524b3d4dba17245671872ef8c24cf. The repository keeps no record of which specification the committed models came from (only the hashes of the generated files); that is why this could not be told apart from a hand edit without regenerating, and it is noted for tech debt.The snapshot was refreshed for DataLens only (
scripts/api_drift.py --refresh datalens); the other services were not fetched.Checked
uv run pytest: 6952 passed, 5 skipped, coverage 100% (lines and branches);lint-imports,ty,ruffclean;scripts/gen_datalens_models.py --checkpasses; pre-commit hooks passed on the commit.Not run
includeFavoritewas not tried.scripts/api_drift.py --livefor the other services.🤖 Generated with Claude Code