Repository navigation
docs: ask in the PR template whether the issue was assigned - #171
Merged
Merged
Conversation
Also drops the test count from the checklist: it said 93+, and the suite is past 350.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR template's checklist now starts with "This PR is for an issue assigned to me, or it fixes a typo or a broken link", linking to the claim-first rule added to
CONTRIBUTING.mdin #170.It also drops the test count from the
cargo testline: it said "93+", and the suite is past 350.Type of Change
Checklist
cargo testand all tests pass. (docs only)cargo clippy --all-targetsand resolved all warnings. (docs only)cargo fmt. (docs only)