Add Location History handler#7
Open
MeurillonGuillaume wants to merge 9 commits into
Open
Conversation
added 8 commits
August 9, 2020 16:56
MeurillonGuillaume
requested review from
BertSchoovaerts,
Driesvanransbeeck,
antoinerichez and
xivk
Contributor
antoinerichez
left a comment
antoinerichez
left a comment
There was a problem hiding this comment.
Looks fine to me, except for the date (is it particularly chosen or just a random one to give the format to use?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
She's finally here!
The long awaited Google Location History file processor. For context, see issue #6.
Code can still use some cleanups though, such as adding the structs from
location-history-handler.gointo the go-bike-data-lib.Let me know what you think! 🎉