fix(release): give the release-kit Compose stack its own project name#273
Merged
Conversation
The release kit previously reused the "guard-proxy" project name, which collides with docker/docker-compose.yml's volumes and containers on a machine that also has a source checkout running. Discovered while smoke-testing v0.1.0-beta.1: starting the release kit silently reused the dev stack's postgres volume and clobbered its running containers.
There was a problem hiding this comment.
Pull request overview
This PR prevents Docker Compose project-name collisions between the release-kit stack (release/docker-compose.yml) and the development stack (docker/docker-compose.yml) when both are run on the same machine, avoiding unintended container/volume reuse.
Changes:
- Sets an explicit Compose project name for the release-kit stack (
name: guard-proxy-release) so it no longer defaults to / reusesguard-proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/docker-compose.ymlreused theguard-proxyproject name, colliding withdocker/docker-compose.yml's containers/volumes on a machine that also has a source checkout.Test plan
pgdatavolume (auth failure against a differently-seeded password) and replaced its running containers.-p guard-proxy-release-smoketest(now the default vianame:) — all 5 services became healthy, frontend/backend/HAProxy responded correctly, dev stack volumes were left untouched.