fix: guard handleDragStart in show-more popup (#2786)#2792
Open
joemcbroom wants to merge 1 commit into
Open
Conversation
joemcbroom
force-pushed
the
fix/2786-popup-handleDragStart-guard
branch
from
fec0926 to
0123c12
Compare
Check that handleDragStart is a function before calling it when user drags an event from the show-more popup. Prevents Uncaught TypeError when the optional prop is not set.
joemcbroom
force-pushed
the
fix/2786-popup-handleDragStart-guard
branch
from
0123c12 to
6d2ffe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2786
When the show-more popup is open and the user drags an event, the code called
handleDragStartwithout checking if it was provided. That optional prop is not always set, which causedUncaught TypeError: handleDragStart is not a function.This change only calls
handleDragStartwhen it is a function (typeof handleDragStart === 'function'), so the popup works when the prop is omitted.