Repository navigation
test: fix the random failures of test_SS.jl:211 - #365
Merged
Merged
Conversation
…ion error The error of a forward difference with step δ depends on the random ci and dci, so a fixed atol = 1e-5 failed at random. The tolerance is now the error bound from nested ForwardDiff second and third derivatives. Claude-Session: https://claude.ai/code/session_01BEoUbvf41HZqywHoqybG7q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_SS.jl:211compares a forward difference withδ = 1e-6to ForwardDiff atatol = 1e-5, but the truncation errorδ f''/2depends on the randomcianddci(a failing run was off by 5.5e-5, sof''was about 110). The tolerance is now that error bound,δ|f''|/2 + δ²|f'''| + 4 eps |f| / δwith a factor 2, withf''andf'''from nested ForwardDiff. The change is in the test only.https://claude.ai/code/session_015sE9Latuiqsp6zSHQ1cshz