Repository navigation
Newton: report a NaN final residual as a failure to converge - #364
Merged
Merged
Conversation
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
verbose = true,solve(prob, Newton(), options)prints "Newton algorithm failed to converge" only whenresiduals[end] > tol(src/Newton.jl:113). A NaN residual makes that comparison false, so a Newton run that ends on a NaN residual returnsconverged = falsewithout the message; the same holds for a final residual equal totol. The returned flag is already right, because line 114 testsresiduals[end] < tol. This PR writes the message condition as the negation of that test,!(residuals[end] < tol), so the message appears whenever the flag says the run failed. A new test intest/newton/test_newton.jlchecks that a residual function returning NaN logs the error and returnsconverged = false.https://claude.ai/code/session_015sE9Latuiqsp6zSHQ1cshz