Repository navigation
PALC: avoid a NaN Secant tangent on zero-length steps - #360
Open
ParadaCarleton wants to merge 1 commit into
Open
ParadaCarleton wants to merge 1 commit into
ParadaCarleton wants to merge 1 commit into
Conversation
…inuation at the current point, so the secant through two equal points never makes a NaN tangent
Member
|
Hi I agree with this but I never saw that in practice. How did you come up with this? I'd be happy to merge but the only point is the test |
ParadaCarleton
added a commit
to ParadaCarleton/BifurcationKit.jl
that referenced
this pull request
Oct 22, 2026
Contributor
Author
Result of #356 (setting |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the step size shrinks below the floating-point resolution of the current point, PALC's corrector can converge to a point equal to the current one in every coordinate, and the
Secanttangent through the two equal points is 0/0, so the next tangent and predictor are NaN. This makescorrector!refuse such a step for aSecanttangent and setstopcontinuation, so the branch ends at the last point it moved to with a finite tangent and predictor (stalled_step). ABorderedtangent is computed at one point and stays defined, so it keeps its current behaviour. The added test intest/continuation/palc_secant_stall.jlrefuses every corrector past λ = 1/2 withdsmin = floatmin(Float32)and checks that the continuation stops below 1/2 with a finite tangent and predictor.