Skip to content

add sv2a pet atlas from NRU to examples#552

Open
bendhouseart wants to merge 8 commits into
masterfrom
atlas-sv2a-nru-pet
Open

add sv2a pet atlas from NRU to examples#552
bendhouseart wants to merge 8 commits into
masterfrom
atlas-sv2a-nru-pet

Conversation

@bendhouseart

Copy link
Copy Markdown
Contributor

Adds PET atlas to examples, will fail validator for version v1.11.1, fix coming in minor release v1.11.2.

@effigies

Copy link
Copy Markdown
Contributor

You're going to add hemi for volumetric data? Or are you using the FS-NIfTI hack for surfaces?

Either way, just use GIFTI.

@CPernet

CPernet commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

I am quite certain the extension should be .mimap and not pet since the values are not PET values anymore (discussed many times in many different threads @mnoergaard

@effigies

Copy link
Copy Markdown
Contributor

If we want to use mimap, we need to finish off bids-standard/bids-specification#2262.

@CPernet

CPernet commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

I agree - we cannot push a PET atlas with the wrong extension

@bendhouseart

Copy link
Copy Markdown
Contributor Author

I agree - we cannot push a PET atlas with the wrong extension

We need to update the spec then as any suffix is allowed. I'd rather change the schema than try to meddle with the spec directly, but maybe that's just me. This PR works with these examples and complies with the spec, so it is possible to have both.

@bendhouseart bendhouseart self-assigned this Apr 17, 2026
@bendhouseart bendhouseart added WIP Work in Progress PET labels Apr 17, 2026
@bendhouseart

Copy link
Copy Markdown
Contributor Author

Inherit some PET metadata:

  • Tracer Name
  • Tracer Radionuclide
  • tbd

@melanieganz

Copy link
Copy Markdown
Contributor

@bendhouseart, while in principle this is ok, but there is a mistake wrt the endings. It should be pet.gii.gz for files on the surface, aka in the tpl-fsaverage folder, and nii.gz in the tpl-MNI152 folders. This is currently switched around, which doesn't make sense. Maybe we should add that to the validator somehow as well to avoid surface files being added into volume templates? But maybe that is out of scope.

@bendhouseart

Copy link
Copy Markdown
Contributor Author

@bendhouseart, while in principle this is ok, but there is a mistake wrt the endings. It should be pet.gii.gz for files on the surface, aka in the tpl-fsaverage folder, and nii.gz in the tpl-MNI152 folders. This is currently switched around, which doesn't make sense. Maybe we should add that to the validator somehow as well to avoid surface files being added into volume templates? But maybe that is out of scope.

Done with d82051d

Per Chris' suggestion (to comply with gifti rules) also updating with .func.gii in commit #054c02edde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PET WIP Work in Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants