add sv2a pet atlas from NRU to examples#552
Conversation
|
You're going to add hemi for volumetric data? Or are you using the FS-NIfTI hack for surfaces? Either way, just use GIFTI. |
|
I am quite certain the extension should be .mimap and not pet since the values are not PET values anymore (discussed many times in many different threads @mnoergaard |
|
If we want to use mimap, we need to finish off bids-standard/bids-specification#2262. |
|
I agree - we cannot push a PET atlas with the wrong extension |
We need to update the spec then as any suffix is allowed. I'd rather change the schema than try to meddle with the spec directly, but maybe that's just me. This PR works with these examples and complies with the spec, so it is possible to have both. |
|
Inherit some PET metadata:
|
|
@bendhouseart, while in principle this is ok, but there is a mistake wrt the endings. It should be pet.gii.gz for files on the surface, aka in the tpl-fsaverage folder, and nii.gz in the tpl-MNI152 folders. This is currently switched around, which doesn't make sense. Maybe we should add that to the validator somehow as well to avoid surface files being added into volume templates? But maybe that is out of scope. |
Done with d82051d Per Chris' suggestion (to comply with gifti rules) also updating with |
…amples into atlas-sv2a-nru-pet
Adds PET atlas to examples, will fail validator for version v1.11.1, fix coming in minor release v1.11.2.