Deliver quit events and survive SDL3's asynchronous fullscreen - #570
Merged
Conversation
AdamCoulterOz
force-pushed
the
fix/runtime-found
branch
4 times, most recently
from
August 4, 2026 15:52
8921260 to
ae9fc1b
Compare
Tearing the video system down waits for the device to go idle, and that wait fails once the device has been lost. The destructor let the failure escape, and a destructor may not throw, so a recoverable graphics error ended the process with an abort during shut-down instead of a clean exit. Report the failure and carry on with the shut-down. The reporting is itself guarded, since a throw from there would end the process just the same. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The system logger adapter asserted that everything reaching it was informational, then logged it as such regardless. The graphics and audio back-ends report genuine warnings and failures through that interface - a lost graphics device among them - so the assertion ended a debug build at the moment something had already gone wrong, and a release build filed the failure away as information. Carry the level across instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The event enumeration has had a quit type all along and the game acts on it, shutting down cleanly, but the SDL back-end never produced one: closing the last window, quitting from the dock or the application menu, and a termination request from the system were all discarded, leaving the process to be killed outright with the configuration unsaved. Translate the event. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
SDL3 applies fullscreen changes asynchronously and defers them entirely for hidden windows, so apply_window_mode's get_size_in_pixels() right after set_window_mode returned the pre-fullscreen 320x240 during startup. The layout, the vanilla raycaster, and the renderer's offscreen chain were then built for that stale size, and a fullscreen boot showed only black while the game ran normally underneath. Size the layout from what was actually requested instead of the live window: set_window_mode now reports the effective size (the chosen closest display mode for exclusive fullscreen, the clamped request for windowed) and syncs where the window can settle. As a backstop, translate SDL_EVENT_WINDOW_PIXEL_SIZE_CHANGED and re-derive the layout whenever the real pixel size diverges - this also covers fake fullscreen on a hidden startup window, whose final size is only known once shown. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AdamCoulterOz
force-pushed
the
fix/runtime-found
branch
from
August 7, 2026 05:00
ae9fc1b to
78ccbc9
Compare
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by running wip; each of these has a user-visible symptom.
🤖 Generated with Claude Code