Skip to content

ZipCodeMask with empty string should be invalid #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JVUnderground wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ZipCodeMask with empty string should be invalid #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c273b2a
included a new zip-code test which checks empty string. Commit also c…
JVUnderground Mar 6, 2018
d71a501
included a new zip-code test which checks empty string. Commit also c…
JVUnderground Mar 6, 2018
b3157af
Merge branch 'master' of https://github.com/JVUnderground/react-nativ…
JVUnderground Mar 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion __tests__/zip-code.mask.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,12 @@ test('11111111 results 11111-111 and raw value 11111111', () => {

expect(received).toBe(expected);
expect(receivedRawValue).toBe(expectedRawValue);
});
});

test('empty string is not valid', () => {
var mask = new ZipCodeMask();
var received = mask.getValue('');
var isValid = mask.validate(received);

expect(isValid).toBe(false)
});
4 changes: 2 additions & 2 deletions lib/masks/zip-code.mask.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ export default class ZipCodeMask extends BaseMask {
return value.length === ZIP_CODE_MASK.length;
}

return true;
return (value.length > 0);
}
}
}
23 changes: 11 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@
"type": "git",
"url": "git+https://github.com/benhurott/react-native-masked-text.git"
},
"keywords": ["mask", "text", "textinput", "react-native"],
"keywords": [
"mask",
"text",
"textinput",
"react-native"
],
"author": "Ben-hur Santos Ott",
"license": "ISC",
"bugs": {
Expand Down