Skip to content

Heroicons 2.1.5#46

Open
alex-ross wants to merge 6 commits intobharget:mainfrom
alex-ross:heroicons-2.1.5
Open

Heroicons 2.1.5#46
alex-ross wants to merge 6 commits intobharget:mainfrom
alex-ross:heroicons-2.1.5

Conversation

@alex-ross
Copy link

@alex-ross alex-ross commented Oct 4, 2024

  • Updates and add new icons from Heroicons 2.1.5 including the new variant micro.
  • Makes dummy app less cumbersome to maintaine.
Skärmavbild 2024-10-04 kl  17 25 19

Fixes: #44, #42

- Resolve conflicts in gem versions
- Use helper to loop through icons instead of require the developer to add them whenever they change.
- Remove unnessesary usage of asset pipeline
- Remove files including only comments
@alex-ross alex-ross mentioned this pull request Oct 5, 2024
@alex-ross
Copy link
Author

Found this https://github.com/jclusso/heroicons now through #42.
Would be great if you could refer to the new repo @jclusso in the README or something. Feels like my time wasn't well spent now 🥺

@jclusso
Copy link

jclusso commented Oct 5, 2024

I'm confused...

@alex-ross
Copy link
Author

@jclusso I understood from what you mentioned in #42 that this gem is no longer maintained and has moved to https://github.com/jclusso/heroicons. But I’m thinking I may misunderstood, maybe you were never involved with this particular repository, and instead, you released an improved version somewhere else?

@jclusso
Copy link

jclusso commented Oct 5, 2024

This repo is dead so I made a new fork and am maintaining it now. I never had any control of this one. If you want to submit a PR, you should submit it on my fork.

@jclusso
Copy link

jclusso commented Oct 5, 2024

Oh I understand, you want this repo to mention the new one.

Nobody has been able to get a response here, so unfortunately it's out of anyone's control. Sorry to hear you wasted your time!

@alex-ross
Copy link
Author

Sorry to hear you wasted your time!

No worries, @jclusso. It was never your fault so sorry for making it sound like that. And I still had a nice time doing the changes 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to 2.1.1

2 participants