Don't crash parser on empty JSON response#12
Open
reist wants to merge 1 commit into
Open
Conversation
Warn instead
bguban
reviewed
Jul 23, 2024
| "responses" => examples.group_by { |ex| ex.response['code'] }.map do |code, variants| | ||
| responses = variants.map do |v| | ||
| parsed = parse_body(v.response) | ||
| puts "Empty response at #{v['description']}, #{route}, HTTP code #{code}" unless parsed |
Owner
There was a problem hiding this comment.
puts doesn't look like a good approach here. The better way is to pass a logger via the initializer and have a default one that will output into the console. Then this logger can be used in the code to provide output
| "responses" => examples.group_by { |ex| ex.response['code'] }.transform_values do |variants| | ||
| { | ||
| "description" => variants.first["description"].capitalize, | ||
| "responses" => examples.group_by { |ex| ex.response['code'] }.map do |code, variants| |
Owner
There was a problem hiding this comment.
responses should be a hash but not an array as I remember. Are you sure that map is a proper method here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn instead