Repository navigation
fix(worker): release completed runs when children inherit output - #263
Merged
benfavre merged 1 commit intoSep 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A completed coding provider can leave a child process holding stdout or stderr open. The worker previously waited for EOF through tee/read pipelines, retaining a busy execution slot after the provider itself exited.
Write provider output directly to the existing private spool files and follow those files only for the exact provider PID's lifetime. Wait for the provider's exit status, drain both log readers, then apply the existing completion-receipt checks. This preserves live stdout/stderr reporting and leaves child processes alive.
Stacked on #262 so the resulting release also includes the Rustls security patch.
Validation:
No live worker was stopped or restarted. Existing stranded pipelines require separately scoped operational cleanup; this change prevents the recurrence for new runs.