This repository was archived by the owner on Apr 16, 2026. It is now read-only.
fix(gizmos): scale child positions on viewport resize + add messages#267
Open
Extermind wants to merge 3 commits intobevyengine:mainfrom
Open
fix(gizmos): scale child positions on viewport resize + add messages#267Extermind wants to merge 3 commits intobevyengine:mainfrom
Extermind wants to merge 3 commits intobevyengine:mainfrom
Conversation
crate When scaling TransformGizmo for viewport size changes, arrow tips and plane handles were not moving proportionally because local translations remained fixed while only GlobalTransform was overridden. Solution manually scales each child's translation vector by viewport_scale when computing final GlobalTransform via gizmo_pos.mul_transform(). Added `bevy_transform_gizmos` crate with `ViewportSize` type and `ViewportResized` message for standardized event-driven viewport management across editor systems. Fixes bevyengine#253
Member
|
Was this intended to be marked as a draft? :) |
Author
|
Yeah, it's because I'm still new to GitHub. I primarily use a different platform for work-related code. Marked as ready for review. |
alice-i-cecile
suggested changes
Apr 11, 2026
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
We definitely shouldn't have a dedicated events crate. We split code by functionality in here :)
The fix itself looks reasonable though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(gizmos): scale child positions on viewport resize + add messages
crate
When scaling TransformGizmo for viewport size changes, arrow tips and
plane
handles were not moving proportionally because local translations
remained
fixed while only GlobalTransform was overridden.
Solution manually scales each child's translation vector by
viewport_scale
when computing final GlobalTransform via gizmo_pos.mul_transform().
Added
bevy_transform_gizmoscrate withViewportSizetype andViewportResizedmessage for standardized event-driven viewport management across editor
systems.
Fixes #253