Use wp_script_attributes to add attributes to the BA script#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the wp_script_attributes filter (WP 5.7+) to add data attributes to the tracking script tag, replacing the previous script_loader_tag + str_replace approach. This operates on the attributes array before HTML generation, as recommended by the WordPress plugin reviewer.
Changes
script_loader_tagfilter withwp_script_attributesfilter for addingdata-*attributes to the tracker scriptadd_tracker_script_attributes()from HTML string manipulation to array-based attribute injection