Refactor admin scripts to use proper WordPress enqueue system#13
Merged
Refactor admin scripts to use proper WordPress enqueue system#13
Conversation
- dashboard link and banner dismiss scripts are now in a single enqueued JS file as per the reviewers request
Woldbye
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors admin JavaScript to use WordPress's proper script enqueue system instead of inline
<script>tags. Consolidates dashboard link and banner dismiss scripts into a single enqueued JS file.Changes
admin/js/betterlytics-admin.jsconsolidating admin scripts as per the wp-reviewers request.enqueue_scripts()method usingwp_enqueue_script()andwp_localize_script()