Refactor tracking script-injection to use wp_enqueue_script()#12
Merged
Refactor tracking script-injection to use wp_enqueue_script()#12
Conversation
Woldbye
changed the title
wp_enqueue_script()
Woldbye
changed the title
wp_enqueue_script()- Add validation to script URL - Add PHPCS ignore for null version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors tracking script injection to comply with WordPress.org plugin guidelines by replacing direct
<script>tag output with properwp_enqueue_script()andwp_add_inline_script()APIs.This followed the suggestion from the latest Wordpress Plugin Review.
Changes
wp_enqueue_script()with WP 6.3+ async strategy for the external tracking scriptwp_add_inline_script()for the event queue buffer and queued events outputdata-*attributeswp_enqueue_scriptswp_enqueue_script()feature they suggest)