Conversation
Améliore le bilan énergétique de la révélation
Fix: data fetching, error handling and auth handling
…e thing only if available comparisons
Feat: anon history
NavBar reads the comparisons context unconditionally since logout() started clearing it, but the admin layout never initialized it, causing a missing_context crash on every /admin/* page.
…ntext fix(front): init comparisons context in admin layout
Add User/UserUpsert/UserPublic split, a generic edit form and a manual add-user flow, replacing the dedicated promote-to-admin modal.
updateComparisonsContext can fail after /auth/logout already cleared the session (eg. sign_in_required blocks /arena/* without one), leaving an unhandled rejection instead of resetting the list.
auth/initAuth were removed from auth.svelte.ts when it moved to a context-based API, but this page still referenced them, causing a 500 on every invite link.
Users created directly from the admin panel had no invite token and no login code, so they fell into the generic "unknown" source bucket alongside users mid email-code signup. Give them their own label.
update_user let a role change silently strip admin access from the last admin, with no equivalent to delete_user's CannotDeleteLastAdminError guard. Add the same protection for role changes.
onSubmit only handled ValidationError; any other error (eg. the 400 "Email already registered" from create_user) was silently swallowed, so the form looked like it did nothing.
The auth-error-on-server-side issue this ssr=false was working around is already handled globally via UnauthorizedError + hooks.server.ts; no other admin upsert page (llms, labs, endpoints, licenses) needs it.
align users admin with LLM backoffice upsert/jsonschema pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#518 (new layout)
#548 (Complete rewrite of LLMs data)
models.jsonto db models./comparia-cli llms exportto export our db llm data to json for other instance to import (to be discussed)./comparia-cli llms importto import from json (to be discussed)./comparia-cli internal types|i18n|allto manage types/constants/archs/i18n internal generationmodels-update.yml#547
#558
#559
#565 (Quickly add history list)
comparison_idparam on all arena routesrevealedandrevealed_atcolumns to Comparison (default to false for previousTodo
TODO
anonymousto User instead of a extra anonymous session cookie?Infra
make db-migrateOPENROUTER_API_KEY,HF_INFERENCE_KEY,ORDBOGEN_API_KEYas env vars to this command to properly migrate and activate endpoints for migration4e31217520ddTest
#547
#558
#559